Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenabled key exchange connection limiter test for macos. #1751

Closed

Conversation

davidv1992
Copy link
Member

@davidv1992 davidv1992 commented Dec 5, 2024

Closes #1525

Fix of underlying cause was in #1739, together with a higher timeout to ensure the test also succeeds on efficiency cores.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.46%. Comparing base (359bdf8) to head (456455b).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1751   +/-   ##
=======================================
  Coverage   81.45%   81.46%           
=======================================
  Files          66       66           
  Lines       20508    20508           
=======================================
+ Hits        16704    16706    +2     
+ Misses       3804     3802    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidv1992 davidv1992 force-pushed the reenable-key-exchange-connection-limiter-test branch from 6a3ea3c to 0c6a3a5 Compare December 5, 2024 14:27
@davidv1992 davidv1992 force-pushed the reenable-key-exchange-connection-limiter-test branch from 0c6a3a5 to 456455b Compare December 5, 2024 15:12
@davidv1992 davidv1992 requested a review from rnijveld December 5, 2024 15:21
rnijveld
rnijveld previously approved these changes Dec 11, 2024
@rnijveld rnijveld changed the base branch from main to support-multiple-rustls December 13, 2024 11:08
Base automatically changed from support-multiple-rustls to main December 13, 2024 11:30
@rnijveld rnijveld dismissed their stale review December 13, 2024 11:30

The base branch was changed.

@rnijveld
Copy link
Member

This was merged together with #1767

@rnijveld rnijveld closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix test for macos
2 participants