Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get postal cities countries from pelias-config #306

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NairolfL
Copy link

👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.


Here's the reason for this change 🚀


Here's what actually got changed 👏

  • Added the possibility to configure the postal cities countries via pelias-config

Running the tests should work as it used to as the default countries are the same.
Configuring imports.adminLookup.postalCitiesCountries (array) should load the configured countries instead of default ones

@NairolfL NairolfL force-pushed the feat/postal-cities-config branch from f8a81b3 to 5080feb Compare May 18, 2021 12:18
@missinglink
Copy link
Member

Hi @NairolfL, what's the status of this, do you want to bring it out of draft or should we close it?
I feel like this is a nice thing to have, did you find it useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants