Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to winston v3 #53

Open
missinglink opened this issue Mar 12, 2020 · 1 comment
Open

upgrade to winston v3 #53

missinglink opened this issue Mar 12, 2020 · 1 comment

Comments

@missinglink
Copy link
Member

missinglink commented Mar 12, 2020

Some changes were made to Winston between versions 2 & 3.
https://github.com/winstonjs/winston/blob/master/UPGRADE-3.0.md

I think it would be beneficial to increase our test coverage in this repo to cover usage of the library by external Pelias modules.
Exporting winston in index.js adds complexity to that task, maybe we remove that export to isolate functionality in the future.

See https://github.com/winstonjs/winston/blob/master/UPGRADE-3.0.md

@orangejulius
Copy link
Member

Oh yeah, I remember looking at this when #43 was opened.

Winston can do a lot!

We should probably make better use of it. I think it will take some time to learn but it would probably be well worth it for us to sit down, examine our usage of logging, learn Winston features, and develop some best practices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants