Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples use port 3100, this port is NOT in the docker-compose file #279

Open
mabushey opened this issue Feb 12, 2021 · 1 comment
Open
Labels

Comments

@mabushey
Copy link

https://github.com/pelias/documentation/blob/master/services.md :

http://localhost:3100/v1/reverse?point.lon=-73.986027&point.lat=40.748517: a reverse geocode for results near the Empire State Building in New York City.

That port does not exist in the docker-compose configs. What service do I want to send the request to?

✗  grep PORT docker-compose.yml  
    environment: [ "PORT=4000" ]
    environment: [ "PORT=4100" ]
    environment: [ "PORT=4300" ]
    environment: [ "PORT=4200" ]

I'm going to guess it's 4100 which is placeholder, although 4000 is api which seems to make more sense
.

@mabushey mabushey added the bug label Feb 12, 2021
@Joxit
Copy link
Member

Joxit commented Feb 19, 2021

Port 3100 is the default port of the API for developers.
The docker compose is a deployment example which redefine port for all services.

I think we can't change default ports because this will be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants