-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created a PR to Support Redis for message passing between client #195
base: master
Are you sure you want to change the base?
Conversation
I myself am in need of this feature as well. Perhaps it is however better to abstract the redis portion, to allow for different backends such as memcache. Also there's quite a few console logs left. |
yeah i will remove the console.log. Let me check how we can abstract the Radis part away. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why files permissions was changed?
} | ||
cert: "", | ||
}, | ||
redis: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd rather suggest to use an object to describe redis config:
redis: {
host: "",
port: 0,
}
@@ -8,6 +8,8 @@ import { Client, IClient } from "../../models/client"; | |||
import { IRealm } from "../../models/realm"; | |||
import { MyWebSocket } from "./webSocket"; | |||
|
|||
const Redis = require("ioredis"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use import instead
Like @KaiserKarel said, we should use an abstraction to transfer/handle messages. I have an idea how to do it. I suggest to move this PR to separate package to extends peerjs server with Redis. Others stuff like RabbitMQ, Memcache etc also should be separated packages. |
Hey just wondering if there are any updates on this PR? would be intersted to try it out |
THIS PROJECT SEEMS COOL THX |
Ability to use Redis Pub Sub to pass messaged between webrtc clients connected across mutiple servers.