-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused input from previous experiments in suites #98
Comments
I think that this is just because we were lazy to do it better from the onset.
👍 IMHO the implementation should be based on some sort of Graph analysis which determines whether an input is going to be needed later in the suite or not. |
Sorry it is not clear to me whether we talk about |
I mean the DataSet beans from the experiment inputs. 👍 for the graph analysis, instead of only checking the previous experiment. Then we can also make it by default. Do you think we should extend that also to the output data, to achieve suite with dependencies on previous output? |
Here is an idea for the implementation:
I suggest to introduce flags |
Actually I already have a prototype for the inputs only, but I could extend it for the output sets as well. Its not based on the graph though. There are actually two problems regarding the configuration:
In the prototype, i did the implementation on the unresolved paths, but IMO we have to do it on the resolved paths. I just ref this here for future discussions. |
Currently we only remove the output from previous experiments when executing a suite.
I experienced some problems lately in suites with lots of different input data while having a fixed system and cluster setup. This resulted in out of disk space errors because the input of previous experiments used all the disk space.
I would suggest we introduce a flag for suites which, when enabled, removes input from previous experiments (if not needed by the current experiment).
I would be up to integrate this feature but I'm not sure if we should make it the default or enable it by flag.
The text was updated successfully, but these errors were encountered: