Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

Add WAC tests in github actions #21

Open
michielbdejong opened this issue Sep 3, 2023 · 10 comments
Open

Add WAC tests in github actions #21

michielbdejong opened this issue Sep 3, 2023 · 10 comments

Comments

@michielbdejong
Copy link
Member

michielbdejong commented Sep 3, 2023

With #20 the test/surface/run-solid-test-suite.sh script will run in github actions, but that script is now only running the solid-CRUD-tests. It should also run the Web-Access-Control-tests.

@mrvahedi68 yesterday you said:

I tried many things to pass web access control tests but all of them failed.

Can you write a comment on this issue detailing which things you tried and how they failed?

@mrvahedi68
Copy link

I checked out web-access-control-test from run-against-css branch and after starting CSS with npm start on port 3000 called ./run-against-css.sh from WAC.

Result:
Failed all tests

@mrvahedi68
Copy link

Created a sh file and replaced with run-against-css.sh in WAC with this configs:

    #!/bin/bash
    set -e
    export WEBID_ALICE=http://localhost:3000/profile/card#me
    export OIDC_ISSUER_ALICE=http://localhost:3000
    export STORAGE_ROOT_ALICE=http://localhost:3000/
    export WEBID_BOB=http://localhost:30001/profile/card#me
    export OIDC_ISSUER_BOB=http://localhost:30001
    export STORAGE_ROOT_BOB=http://localhost:30001/

Result: Failed all tests.

@mrvahedi68
Copy link

Cloned NSS and ran it and called the default run-against-css.sh from WAC with one difference for replacing HELP_SERVER_HOST=solidcommunity.net with HELP_SERVER_HOST=localhost:8443.

Result: Failed all tests.

@mrvahedi68
Copy link

Ran NSS with docker and map 443 port from container to host, then replaced HELP_SERVER_HOST=solidcommunity.net with HELP_SERVER_HOST=localhost.

Result: Failed all tests

@mrvahedi68
Copy link

Comment out line 16 of ./node_modules/@solid/access-token-verifier/dist/algorithm/verifySolidAccessTokenIssuer.js for this issue. then ran with solidcommunity.net help server.

Result: All tests failed.

@mrvahedi68
Copy link

going to run tests again with online NSS.

@mrvahedi68
Copy link

Check for existing https://tester as trusted app for this users:

  • solidtestsuite
  • solid-crud-tests-example-2

@mrvahedi68
Copy link

WAC tests passing with one failing:

Screen Shot 1402-06-13 at 00 40 42

@mrvahedi68
Copy link

Related PR: #22
@michielbdejong

@mrvahedi68
Copy link

new issue for failing test: #23

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants