Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conda Deployment Fix #399

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Conda Deployment Fix #399

merged 2 commits into from
Jan 5, 2024

Conversation

CodeGat
Copy link
Collaborator

@CodeGat CodeGat commented Jan 5, 2024

In this PR:

  • Updating the meta.yml file to require python <=3.11 so we can import imp.
  • Updated the CI pipeline to attempt to build payu via conda as well, so we can catch future errors of the above sort before we merge into master.

Closes #395

@CodeGat CodeGat requested a review from aidanheerdegen January 5, 2024 03:36
@CodeGat CodeGat self-assigned this Jan 5, 2024
@CodeGat CodeGat changed the title 395 deployment fix Conda Deployment Fix Jan 5, 2024
@coveralls
Copy link

Coverage Status

coverage: 52.591%. remained the same
when pulling fc7e296 on ACCESS-NRI:395-deployment-fix
into be0841d on payu-org:master.

aidanheerdegen
aidanheerdegen approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A weird error that took quite a bit to track down. Thanks.

@CodeGat CodeGat merged commit ca0c825 into payu-org:master Jan 5, 2024
9 checks passed
@CodeGat CodeGat deleted the 395-deployment-fix branch January 5, 2024 04:15
@dougiesquire dougiesquire mentioned this pull request Jan 17, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidanheerdegen aidanheerdegen aidanheerdegen approved these changes

Assignees

@CodeGat CodeGat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deployment fails with python >= 3.12
3 participants
@CodeGat @coveralls @aidanheerdegen