From a1b660505bd5a3e640d7a2599f5250fd4e6dc1f7 Mon Sep 17 00:00:00 2001 From: Boby <73424060+bobychaudhary@users.noreply.github.com> Date: Sat, 25 Dec 2021 13:44:42 +0530 Subject: [PATCH] Update README.md Minor typo mistakes --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index e002d5a..404b130 100644 --- a/README.md +++ b/README.md @@ -209,7 +209,7 @@ ruleEngineObject.getLoadedMeta() ``` ### Meta Object -Meta object saves the state of each rule , condition and action with variups required timestamps. It is not in the scope of this project to analyze the performace/metrics of the engine/rules. +Meta object saves the state of each rule , condition and action with various required timestamps. It is not in the scope of this project to analyze the performance/metrics of the engine/rules. This can help in re-arranging conditions, removing redundant /slow rules, etc. . Idea should be to minimize the number of conditions/rules for each message. Schema of meta object @@ -263,7 +263,7 @@ Fastest is native - Why will we never support 'calling rules' with multiple tag options ? : Then conditional operators among tags will be a major requirement and tags are essentially rule groups. - Changing Rule Engine execution from sync to async : - + While sync offered a lot more performance benefit , ease of usage and code simplicity , it lacked a majority extensibility , i.e. executing cutom functions in code flows. Conditions, while sync, are forcefully made async to keep the options open, and to keep performance realistic. + + While sync offered a lot more performance benefit , ease of usage and code simplicity , it lacked a majority extensibility , i.e. executing custom functions in code flows. Conditions, while sync, are forcefully made async to keep the options open, and to keep performance realistic. ### Todo / improvements / known Bugs @@ -271,4 +271,4 @@ Fastest is native - Rule Snapshots ? Rule Audits ? - How to define a common Rules language ? Currently Rules are picked from DB. Is that standard way , or should we define an API for this ? - Give a GUI to manage Rules/ get status/ get active Rules, etc... -- Performance bnechmark \ No newline at end of file +- Performance benchmark