Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building fail with v2, send features @ v0.15 #258

Closed
jbesraa opened this issue May 21, 2024 · 4 comments · Fixed by #261
Closed

Building fail with v2, send features @ v0.15 #258

jbesraa opened this issue May 21, 2024 · 4 comments · Fixed by #261

Comments

@jbesraa
Copy link
Contributor

jbesraa commented May 21, 2024

I was not able to reproduce this in rust-payjoin while building it locally but in pr https://github.com/lightningdevkit/ldk-node/pull/295/checks iam not able to only include v2, send, it throws the following error
Screenshot from 2024-05-21 10-12-34

rand is re-exported with receive feature so adding the receive would make it compile.
@jbesraa jbesraa changed the title Building fail with v2, send feature on v0.15 Building fail with v2, send features @ v0.15 May 21, 2024
@DanGould
Copy link
Contributor

The link you shared goes only to the most recent checks on lightningdevkit/ldk-node#295. May you please share the exact check that fails?

@DanGould DanGould mentioned this issue May 21, 2024
Merged
@DanGould
Copy link
Contributor

Do the changes in #261 fix your issue?

@jbesraa
Copy link
Contributor Author

jbesraa commented May 22, 2024

The link you shared goes only to the most recent checks on lightningdevkit/ldk-node#295. May you please share the exact check that fails?

I didnt push the code without the receive feature as it failed to compile, to reproduce it locally you can remove the receive in this commit lightningdevkit/ldk-node@532c6ef and try to build.

#261 solved the problem. Thanks.

@jbesraa
Copy link
Contributor Author

jbesraa commented May 22, 2024 •
edited
Loading

If you have the time, I would appreciate your input on the PR lightningdevkit/ldk-node#295 (not able to tag you in the pr for some reason). It adds a payjoin sender implementation to ldk node.

@jbesraa jbesraa mentioned this issue May 22, 2024
Open
DanGould added a commit that referenced this issue May 22, 2024
@DanGould
Depend on bitcoin/rand for rand (#261)
1248694 
Rand is already available in secp256k1/rand transiently through rust
bitcoin. rand-std is also an option to for std environments but having
wide support seems more important in the near term than adding all of
those feature flags.

This fixes #258 which
may have been triggering in an environment where bitcoin/rand was not
available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Depend on bitcoin/rand for rand DanGould/rust-payjoin
2 participants
@DanGould @jbesraa