From 5d9fc9b223a9b0d845382936129a956fa43e7576 Mon Sep 17 00:00:00 2001 From: Jesse Beeson Date: Mon, 4 Feb 2019 22:12:38 -0500 Subject: [PATCH 1/2] Added 64-bit support. Option q. --- devmem2.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/devmem2.c b/devmem2.c index 7803b32..72af353 100644 --- a/devmem2.c +++ b/devmem2.c @@ -61,7 +61,7 @@ int main(int argc, char **argv) { int fd; void *map_base, *virt_addr; - unsigned long read_result = -1, writeval=-1; + uint64_t read_result = -1, writeval=-1; uint64_t target; int access_type = 'w'; int access_size = 4; @@ -140,11 +140,14 @@ int main(int argc, char **argv) case 'b': access_size = 1; break; + case 'h': + access_size = 2; + break; case 'w': access_size = 4; break; - case 'h': - access_size = 2; + case 'q': + access_size = 8; break; default: printerr("Illegal data type: %s\n", argv[2]); @@ -198,7 +201,7 @@ int main(int argc, char **argv) if (argc > 3) { errno = 0; - writeval = strtoul(argv[3], &endp, 0); + writeval = strtoull(argv[3], &endp, 0); if (errno || (endp && 0 != *endp)) { printerr("Invalid data value: %s\n", argv[3]); exit(2); @@ -219,6 +222,9 @@ int main(int argc, char **argv) case 4: *((volatile uint32_t *) virt_addr) = writeval; break; + case 8: + *((volatile uint64_t *) virt_addr) = writeval; + break; } if (f_dbg) { @@ -238,6 +244,9 @@ int main(int argc, char **argv) case 4: read_result = *((volatile uint32_t *) virt_addr); break; + case 8: + read_result = *((volatile uint64_t *) virt_addr); + break; } //printf("Value at address 0x%lld (%p): 0x%lu\n", (long long)target, virt_addr, read_result); From 830b7ed4f7ae314050c55213cedbb66168553514 Mon Sep 17 00:00:00 2001 From: Brent Yates Date: Thu, 15 Aug 2019 22:58:16 -0400 Subject: [PATCH 2/2] Added x option to test 128-bit writes. Added timer to write loop. --- .gitignore | 2 + Makefile | 1 + devmem2.c | 219 ++++++++++++++++++++++++++++++++++++----------------- 3 files changed, 151 insertions(+), 71 deletions(-) diff --git a/.gitignore b/.gitignore index bbf313b..b7ec832 100644 --- a/.gitignore +++ b/.gitignore @@ -27,6 +27,8 @@ *.i*86 *.x86_64 *.hex +devmem2 +list.s # Debug files *.dSYM/ diff --git a/Makefile b/Makefile index 67e2c65..e2ebcab 100644 --- a/Makefile +++ b/Makefile @@ -11,6 +11,7 @@ SRC=devmem2.c devmem2: $(SRC) $(CC) $(CFLAGS) $(LDFLAGS) $(LIBS) -o $@ $(SRC) + objdump -d -M intel -SlW $@ > list.s # Install as "devmem2" install: diff --git a/devmem2.c b/devmem2.c index 72af353..ee5d43a 100644 --- a/devmem2.c +++ b/devmem2.c @@ -36,8 +36,15 @@ #include #include #include +#include +#include -#define printerr(fmt,...) do { fprintf(stderr, fmt, ## __VA_ARGS__); fflush(stderr); } while(0) +#define printerr(fmt, ...) \ + do \ + { \ + fprintf(stderr, fmt, ##__VA_ARGS__); \ + fflush(stderr); \ + } while (0) #define VER_STR "devmem version T/C (http://git.io/vZ5iD) rev.0.3e" @@ -46,22 +53,38 @@ int f_dbg = 0; static void usage(const char *cmd) { fprintf(stderr, "\nUsage:\t%s [-switches] address [ type [ data ] ]\n" - "\taddress : memory address to act upon\n" - "\ttype : access operation type : [b]yte, [h]alfword, [w]ord\n" - "\tdata : data to be written\n\n" - "Switches:\n" - "\t-r : read back after write\n" - "\t-a : do not check alignment\n" - "\t--version | -V : print version\n" - "\n", - cmd); + "\taddress : memory address to act upon\n" + "\ttype : access operation type : [b]yte, [h]alfword, [w]ord, [q]word\n" + "\tdata : data to be written\n\n" + "Switches:\n" + "\t-r : read back after write\n" + "\t-a : do not check alignment\n" + "\t--version | -V : print version\n" + "\n", + cmd); } +#if 1 +void Write16ByteAligned(const __m128i* data, void* pDestination) +{ + _mm_store_si128((__m128i *)pDestination, *data); + +} + +uint64_t get_time_tick() +{ + struct timespec temp; + clock_gettime(CLOCK_REALTIME, &temp); + return((temp.tv_sec * 1000000000) + temp.tv_nsec); +} + +#endif + int main(int argc, char **argv) { int fd; void *map_base, *virt_addr; - uint64_t read_result = -1, writeval=-1; + uint64_t read_result = -1, writeval = -1; uint64_t target; int access_type = 'w'; int access_size = 4; @@ -69,55 +92,67 @@ int main(int argc, char **argv) unsigned int map_size = pagesize; unsigned offset; char *endp = NULL; - int f_readback = 0; // flag to read back after write + int f_readback = 0; // flag to read back after write int f_align_check = 1; // flag to require alignment + int f_loop = 1; // flag to do looping const char *progname = argv[0]; int opt; opterr = 0; - while ((opt = getopt(argc, argv, "+raAdV")) != -1) { - switch(opt) { + while ((opt = getopt(argc, argv, "+raAdVl:")) != -1) + { + switch (opt) + { case 'r': f_readback = 1; break; case 'a': f_align_check = 0; break; - case 'A': + case 'A': // Absolute address mode. Does nothing now, for future compat.; break; case 'd': f_dbg = 1; break; - case 'V': + case 'l': + f_loop = strtoull(optarg, &endp, 0); + ; + break; + case 'V': printf(VER_STR "\n"); exit(0); default: - if ( (!argv[optind]) || 0 == strcmp(argv[optind], "--help")) { + if ((!argv[optind]) || 0 == strcmp(argv[optind], "--help")) + { usage(progname); exit(1); } - if (0 == strncmp(argv[optind], "--vers", 6)) { - printf(VER_STR "\n"); - exit(0); + if (0 == strncmp(argv[optind], "--vers", 6)) + { + printf(VER_STR "\n"); + exit(0); } - printerr("Unknown long option: %s\n", argv[optind]); - exit(2); + printerr("Unknown long option: %s\n", argv[optind]); + exit(2); } } argc -= optind - 1; argv += optind - 1; - if (argc < 2 || argc > 4) { + if (argc < 2 || argc > 4) + { usage(progname); exit(1); } - if (argc > 2) { - if (!isdigit(argv[1][0])) { + if (argc > 2) + { + if (!isdigit(argv[1][0])) + { // Allow access_type be 1st arg, then swap 1st and 2nd char *t = argv[2]; argv[2] = argv[1]; @@ -125,62 +160,73 @@ int main(int argc, char **argv) } access_type = tolower(argv[2][0]); - if (argv[2][1] ) + if (argv[2][1]) access_type = '?'; } errno = 0; target = strtoull(argv[1], &endp, 0); - if (errno != 0 || (endp && 0 != *endp)) { + if (errno != 0 || (endp && 0 != *endp)) + { printerr("Invalid memory address: %s\n", argv[1]); exit(2); } - switch (access_type) { - case 'b': - access_size = 1; - break; - case 'h': - access_size = 2; - break; - case 'w': - access_size = 4; - break; - case 'q': - access_size = 8; - break; - default: - printerr("Illegal data type: %s\n", argv[2]); - exit(2); + switch (access_type) + { + case 'b': + access_size = 1; + break; + case 'h': + access_size = 2; + break; + case 'w': + access_size = 4; + break; + case 'q': + access_size = 8; + break; + case 'x': + access_size = 16; + break; + default: + printerr("Illegal data type: %s\n", argv[2]); + exit(2); } - if ((target + access_size -1) < target) { + if ((target + access_size - 1) < target) + { printerr("ERROR: rolling over end of memory\n"); exit(2); } - if ( (sizeof(off_t) < sizeof(int64_t)) && (target > UINT32_MAX) ) { + if ((sizeof(off_t) < sizeof(int64_t)) && (target > UINT32_MAX)) + { printerr("The address %s > 32 bits. Try to rebuild in 64-bit mode.\n", argv[1]); // Consider mmap2() instead of this check exit(2); } - offset = (unsigned int)(target & (pagesize-1)); - if (offset + access_size > pagesize ) { + offset = (unsigned int)(target & (pagesize - 1)); + if (offset + access_size > pagesize) + { // Access straddles page boundary: add another page: map_size += pagesize; } - if (f_dbg) { + if (f_dbg) + { printerr("Address: %#" PRIX64 " op.size=%d\n", target, access_size); } - if (f_align_check && offset & (access_size - 1)) { + if (f_align_check && offset & (access_size - 1)) + { printerr("ERROR: address not aligned on %d!\n", access_size); exit(2); } fd = open("/dev/mem", O_RDWR | O_SYNC); - if (fd == -1) { + if (fd == -1) + { printerr("Error opening /dev/mem (%d) : %s\n", errno, strerror(errno)); exit(1); } @@ -188,9 +234,10 @@ int main(int argc, char **argv) //fflush(stdout); map_base = mmap(0, map_size, PROT_READ | PROT_WRITE, MAP_SHARED, - fd, - target & ~((typeof(target))pagesize-1)); - if (map_base == (void *) -1) { + fd, + target & ~((typeof(target))pagesize - 1)); + if (map_base == (void *)-1) + { printerr("Error mapping (%d) : %s\n", errno, strerror(errno)); exit(1); } @@ -199,54 +246,82 @@ int main(int argc, char **argv) virt_addr = map_base + offset; - if (argc > 3) { + if (argc > 3) + { + int i; errno = 0; writeval = strtoull(argv[3], &endp, 0); - if (errno || (endp && 0 != *endp)) { + if (errno || (endp && 0 != *endp)) + { printerr("Invalid data value: %s\n", argv[3]); exit(2); } - if (access_size < sizeof(writeval) && 0 != (writeval >> (access_size * 8))) { + if (access_size < sizeof(writeval) && 0 != (writeval >> (access_size * 8))) + { printerr("ERROR: Data value %s does not fit in %d byte(s)\n", argv[3], access_size); exit(2); } - switch (access_size) { + uint64_t start_tick = get_time_tick(); + for (i = 0; i < f_loop; i++) + { + switch (access_size) + { case 1: - *((volatile uint8_t *) virt_addr) = writeval; + *((volatile uint8_t *)virt_addr) = writeval; break; case 2: - *((volatile uint16_t *) virt_addr) = writeval; + *((volatile uint16_t *)virt_addr) = writeval; break; case 4: - *((volatile uint32_t *) virt_addr) = writeval; + *((volatile uint32_t *)virt_addr) = writeval; break; case 8: - *((volatile uint64_t *) virt_addr) = writeval; + *((volatile uint64_t *)virt_addr) = writeval; + break; + case 16: + { + uint64_t dx[2] __attribute__ ((aligned (16))) = {writeval,~writeval}; + Write16ByteAligned((__m128i *)&dx, virt_addr); break; + } + } } - - if (f_dbg) { + uint64_t stop_tick = get_time_tick(); + uint64_t delta_tics = stop_tick - start_tick; + if (f_loop > 1) + { + printf("%i writes in %f ms.\n", f_loop, delta_tics / 1000000.0); + printf("%f ns per write.\n", (double)delta_tics / f_loop); + } + if (f_dbg) + { printerr("Address: %#" PRIX64 " Written: %#lX\n", target, writeval); fflush(stdout); } } - - if (argc <= 3 || f_readback) { - switch (access_size) { + + if (argc <= 3 || f_readback) + { + int i; + for (i = 0; i < f_loop; i++) + { + switch (access_size) + { case 1: - read_result = *((volatile uint8_t *) virt_addr); + read_result = *((volatile uint8_t *)virt_addr); break; case 2: - read_result = *((volatile uint16_t *) virt_addr); + read_result = *((volatile uint16_t *)virt_addr); break; case 4: - read_result = *((volatile uint32_t *) virt_addr); + read_result = *((volatile uint32_t *)virt_addr); break; case 8: - read_result = *((volatile uint64_t *) virt_addr); + read_result = *((volatile uint64_t *)virt_addr); break; + } } //printf("Value at address 0x%lld (%p): 0x%lu\n", (long long)target, virt_addr, read_result); @@ -258,7 +333,8 @@ int main(int argc, char **argv) fflush(stdout); } - if (munmap(map_base, map_size) != 0) { + if (munmap(map_base, map_size) != 0) + { printerr("ERROR munmap (%d) %s\n", errno, strerror(errno)); } @@ -266,3 +342,4 @@ int main(int argc, char **argv) return 0; } +