Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Wizard): add className props and spread them when possible #10670

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

nicolethoen
Copy link
Contributor

What: Closes #10665

unblocks an issue in quickstarts v6 migrations

Copy link
Contributor

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests for these added props would be great to have IMO, but other than that and it looking like the lock file needs an update LGTM.

Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm once build goes through

@nicolethoen
Copy link
Contributor Author

I'll add tests later today 👍🏻

@patternfly-build
Copy link
Contributor

patternfly-build commented Jun 27, 2024

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also make this change on main.

Copy link
Contributor

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@tlabaj tlabaj merged commit b7654e1 into patternfly:v6 Jul 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Wizard - props not being spread in various child components
6 participants