Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileUpload - Expose Dropzone Error Types #10521

Open
andrewballantyne opened this issue Jun 4, 2024 · 7 comments · May be fixed by #11289
Open

FileUpload - Expose Dropzone Error Types #10521

andrewballantyne opened this issue Jun 4, 2024 · 7 comments · May be fixed by #11289
Assignees
@mfrances17
Labels
Release blocking
Milestone
2024.Q4

Comments

@andrewballantyne
Copy link

Is this a new component or an extension of an existing one?
Existing component: FileUpload

Describe the feature
Hey! Is there anyway to get access to Dropzone’s ErrorCode enum in TypeScript for when it rejects a drag and drop and you want to look for a specific error?

Eg. Using the FileUpload Component & providing this prop:

dropzoneProps={{
  onDropRejected: (rejections) => {
    const error = rejections[0].errors[0];
    if (error.code === ErrorCode.FileTooLarge) {
...

Are there visuals for this feature? If applicable, please include examples for each state and for varying widths
N/A

Any other information?

Exposing internals of dropzone but making it difficult to write app layers against it feels like a bug more than a feature request -- but I figured this is at min a valid feature request.
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jun 4, 2024
@tlabaj tlabaj moved this from Needs triage to On deck in PatternFly Issues Jun 4, 2024
@tlabaj tlabaj added this to the 2024.Q2 milestone Jun 4, 2024
@nicolethoen nicolethoen moved this from On deck to Not started in PatternFly Issues Jun 4, 2024
@tlabaj
Copy link
Contributor

tlabaj commented Jun 4, 2024

@andrewballantyne when do you need this feature by?

@andrewballantyne
Copy link
Author

I've inspected the types and just copied the underlying value -- I'd like it before Dropzone changes their implementation / types obviously... but I guess that's up to you. The sooner you do it the sooner I can close my tech debt to convert over to the proper type 🙂

Please don't put it into the trash can by any means haha ... but I don't know the effort to expose such a type inside your world.

@kmcfaul kmcfaul modified the milestones: 2024.Q2, 2024.Q3 Jun 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

This issue has been automatically marked as stale because it has not had recent activity.

@github-actions github-actions bot added the Stale label Aug 5, 2024
@andrewballantyne
Copy link
Author

@tlabaj is this issue no longer a plan for PF? The issue is stale as of yesterday, is this a way to prune issues that don't have strict deadlines?

@github-actions github-actions bot removed the Stale label Aug 9, 2024
@andrew-ronaldson andrew-ronaldson modified the milestones: 2024.Q3, 2024.Q4 Aug 22, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@tlabaj tlabaj removed the wontfix label Oct 25, 2024
@tlabaj
Copy link
Contributor

tlabaj commented Oct 25, 2024

@andrewballantyne we will add this to our q4 milestone. Is this something you need in V5?

@andrewballantyne
Copy link
Author

Nope, v6 is fine.

@kmcfaul kmcfaul removed the Feature label Oct 25, 2024
@kmcfaul kmcfaul moved this from Not started to Ready to assign in PatternFly Issues Nov 13, 2024
@mfrances17 mfrances17 self-assigned this Nov 14, 2024
@mfrances17 mfrances17 moved this from Ready to assign to Not started in PatternFly Issues Nov 14, 2024
@mfrances17 mfrances17 moved this from Not started to In Progress in PatternFly Issues Nov 20, 2024
@mfrances17 mfrances17 linked a pull request Nov 25, 2024 that will close this issue
Open
@mfrances17 mfrances17 moved this from In Progress to PR Review in PatternFly Issues Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfrances17 mfrances17

Labels
Release blocking
Projects
PatternFly Issues
Status: PR Review
Milestone
2024.Q4
Development

Successfully merging a pull request may close this issue.

feat(FileUpload): expose dropdown error types mfrances17/patternfly-react
5 participants
@andrewballantyne @andrew-ronaldson @mfrances17 @tlabaj @kmcfaul