Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charts: Victory dependencies should be marked optional #11125

Closed
dlabrecq opened this issue Oct 22, 2024 · 1 comment
Closed

Charts: Victory dependencies should be marked optional #11125

dlabrecq opened this issue Oct 22, 2024 · 1 comment

Comments

@dlabrecq
Copy link
Member

dlabrecq commented Oct 22, 2024 •
edited
Loading

Victory peer dependencies should be marked optional via peerDependenciesMeta

See
https://docs.npmjs.com/cli/v10/configuring-npm/package-json#peerdependenciesmeta

In addition, the release notes should describe Victory as optional peer dependency
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Oct 22, 2024
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Oct 22, 2024
@dlabrecq
fix(charts): update Victory packages to be optional peer dependencies
6f26d69 
patternfly#11125
dlabrecq added a commit to dlabrecq/pf-codemods that referenced this issue Oct 22, 2024
@dlabrecq
chore(release): Update release highlights for react-charts
c8a286f 
patternfly/patternfly-react#11125
dlabrecq added a commit to dlabrecq/patternfly-org that referenced this issue Oct 22, 2024
@dlabrecq
chore(docs): update release highlights to include react-charts
7c5d602 
patternfly/patternfly-react#11125
This was referenced Oct 22, 2024
Merged
Merged
Open
dlabrecq added a commit to dlabrecq/patternfly-org that referenced this issue Oct 22, 2024
@dlabrecq
chore(docs): update release highlights to include react-charts
763df7f 
patternfly/patternfly-react#11125
dlabaj pushed a commit that referenced this issue Oct 22, 2024
@dlabrecq
fix(charts): update Victory packages to be optional peer dependencies (…
09a8f38 
…#11128)

#11125
nicolethoen pushed a commit to patternfly/patternfly-org that referenced this issue Oct 24, 2024
@dlabrecq
chore(docs): update release highlights to include react-charts (#4334)
5e5ab19 
patternfly/patternfly-react#11125
@tlabaj
Copy link
Contributor

tlabaj commented Oct 24, 2024

closed by #11128

@tlabaj tlabaj closed this as completed Oct 24, 2024
@github-project-automation github-project-automation bot moved this from Needs triage to Done in PatternFly Issues Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dlabrecq @tlabaj