Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card titles should be blue to show clickable state. #332

Closed
andrew-ronaldson opened this issue Oct 2, 2024 · 2 comments · Fixed by #334
Closed

Card titles should be blue to show clickable state. #332

andrew-ronaldson opened this issue Oct 2, 2024 · 2 comments · Fixed by #334
Assignees
Labels

Comments

@andrew-ronaldson
Copy link
Contributor

Similar to the actionable + Selectable cards we should update the quickstarts card to have a blue title to indicate it is the clickable target.

Image

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Oct 2, 2024
@nicolethoen nicolethoen self-assigned this Oct 2, 2024
@nicolethoen nicolethoen moved this from Needs triage to In Progress in PatternFly Issues Oct 2, 2024
@andrew-ronaldson
Copy link
Contributor Author

andrew-ronaldson commented Oct 2, 2024

Looks like the quickstart card title is referencing .pf-c-conent--p. which is making it 14px.
On the card component it uses:

<div class="pf-v6-c-card__title">
    <div class="pf-v6-c-card__title-text">Title</div>
</div>

As a result the title in Quickstarts is 14px instead of 16px and it also doesn't use the Red Hat Display font.

Image

@nicolethoen
Copy link
Contributor

nicolethoen commented Oct 3, 2024

i'll update it so that it's not getting wrapped in the content class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants