Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tip admonition block style is not applied correctly in v5 #323

Open
tthvo opened this issue Aug 31, 2024 · 1 comment
Open

Tip admonition block style is not applied correctly in v5 #323

tthvo opened this issue Aug 31, 2024 · 1 comment
Labels
bug Something isn't working P1 ⭐

Comments

@tthvo
Copy link

tthvo commented Aug 31, 2024

Description

When I use the following syntax for an admonition block with TIP variant.

[This is the tip contents]{{admonition tip}}

The block is displayed but its style is incorrect. I expect it to have "custom" variant style as in this doc: https://www.patternfly.org/components/alert#alert-variants.

What I expect to see What I saw instead
image image

Environment

Using v5.3.0 with Patternfly 5.

"@patternfly/quickstarts": "^5.3.0",
"@patternfly/react-catalog-view-extension": "^5.0.0",
"@patternfly/react-charts": "^7.3.0",
"@patternfly/react-core": "^5.3.4",
"@patternfly/react-icons": "^5.3.2",
"@patternfly/react-styles": "^5.3.1",
"@patternfly/react-table": "^5.3.4",
"@patternfly/react-topology": "^5.2.0",

Others

I think a quick fix would be to set the variant of the TIP admonition to custom or simply unset it. See below:

[AdmonitionType.TIP]: { variant: 'default', customIcon: <LightbulbIcon /> },

Reference: https://www.patternfly.org/components/alert#alert

@tthvo
Copy link
Author

tthvo commented Aug 31, 2024

Currently, this is blocking us from upgrading to Patternfly 5 :( Hopefully, there would be a fix soon :D

@dlabaj dlabaj added P1 ⭐ bug Something isn't working labels Sep 4, 2024
@dlabaj dlabaj added this to the 2024.Q3 milestone Sep 6, 2024
@dlabaj dlabaj moved this from Not started to Backlog in PatternFly Issues Nov 6, 2024
@dlabaj dlabaj modified the milestones: 2024.Q3, Prioritized Backlog Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1 ⭐
Projects
Status: Backlog
Development

No branches or pull requests

2 participants