Skip to content

Commit

Permalink
chore(docs): Address feedback
Browse files Browse the repository at this point in the history
Also fixing test with build error after rebase.
  • Loading branch information
rebeccaalpert committed Nov 11, 2024
1 parent 9d328fd commit 82cf309
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,10 @@ To provide users with a more specific direction, you can also include optional w

### Skip to content

To provide page context, we recommend using a "skip to chatbot" button. This allows you to skip past other content on the page, directly to the chatbot content. The [PatternFly skip to content component](/components/skip-to-content) can be used for this purpose. To display this button, you must tab into the main window. When using default or docked modes, we recommend putting focus on the toggle if the chatbot is closed, and the chatbot when it is open. For fullscreen and embedded, we recommend putting the focus on the first focusable item in the chatbot, such as a menu toggle. This can be seen in our more fully-featured demos for the [default, embedded, and fullscreen chatbot](patternfly-ai/chatbot/chatbot-container/react-demos/basic-chatbot) and the [embedded chatbot](/patternfly-ai/chatbot/chatbot-container/react-demos/embedded-chatbot).
To provide page context, we recommend using a "skip to chatbot" button. This allows you to skip past other content on the page, directly to the chatbot content, using a [PatternFly skip to content component](/components/skip-to-content). To display this button, you must tab into the main window.
<br />
<br />
When using default or docked modes, we recommend putting focus on the toggle if the chatbot is closed, and the chatbot when it is open. For fullscreen and embedded, we recommend putting the focus on the first focusable item in the chatbot, such as a menu toggle. This can be seen in our more fully-featured demos for the [default, embedded, and fullscreen chatbot](patternfly-ai/chatbot/chatbot-container/react-demos/basic-chatbot) and the [embedded chatbot](/patternfly-ai/chatbot/chatbot-container/react-demos/embedded-chatbot).

```js file="./SkipToContent.tsx" isFullscreen

Expand Down
10 changes: 5 additions & 5 deletions packages/module/src/ResponseActions/ResponseActions.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ describe('ResponseActions', () => {

it('should be able to change aria labels', () => {
const actions = [
{ type: 'positive', ariaLabel: /Thumbs up/i },
{ type: 'negative', ariaLabel: /Thumbs down/i },
{ type: 'copy', ariaLabel: /Copy the message/i },
{ type: 'share', ariaLabel: /Share it with friends/i },
{ type: 'listen', ariaLabel: /Listen up/i }
{ type: 'positive', ariaLabel: 'Thumbs up' },
{ type: 'negative', ariaLabel: 'Thumbs down' },
{ type: 'copy', ariaLabel: 'Copy the message' },
{ type: 'share', ariaLabel: 'Share it with friends' },
{ type: 'listen', ariaLabel: 'Listen up' }
];
actions.forEach(({ type, ariaLabel }) => {
render(<ResponseActions actions={{ [type]: { onClick: jest.fn(), ariaLabel } }} />);
Expand Down

0 comments on commit 82cf309

Please sign in to comment.