Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit GitHub Stamp to make it more clear that only unique commit days are counted #3177

Open
lebraat opened this issue Jan 10, 2025 · 0 comments

Comments

@lebraat
Copy link
Member

lebraat commented Jan 10, 2025

User Story:

As a user
I want to better understand the criteria of the GitHub stamp
So that I can know how I'm trending towards qualifying for the Stamp

Acceptance Criteria

GIVEN a user who doesn't fully qualify for the GitHub stamp
WHEN they try to verify the stamp
THEN they receive error messages and other details that help them identify how to become eligible for the Stamp.

  1. Update the language in error messages from 'contributions' to 'unique commits' (since we changed the requirements of the stamp a few months ago)
  2. Pair with Daniel to improve the app he's working on to make sure it matches the Stamp so we can use with our support team (and possibly users) if we need deeper support / understanding on the issues.

Product & Design Links:

Current Errors:
"error": "You have contributed on 0 days, the minimum for this stamp is 30 days. Some commits were ignored because they ocurred before the Github repo or user creation."

"error": "You have contributed on 0 days, the minimum for this stamp is 60 days. Some commits were ignored because they ocurred before the Github repo or user creation."

"error": "You have contributed on 0 days, the minimum for this stamp is 120 days. Some commits were ignored because they ocurred before the Github repo or user creation.

Change to the following: (bold words are additions / changes)
"error": "You have contributed on 0 days, the minimum for this stamp is 30 days. Some unique commits were ignored because they occurred before the Github repo or user creation."

"error": "You have contributed on 0 days, the minimum for this stamp is 60 days. Some unique commits were ignored because they occurred before the Github repo or user creation."

"error": "You have contributed on 0 days, the minimum for this stamp is 120 days. Some unique commits were ignored because they occurred before the Github repo or user creation.

If there are other stamp errors for Github that say "contributions" we should update this to "Unique commit days"

@Jkd-eth Jkd-eth moved this to Prioritized in Passport New Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Prioritized
Development

No branches or pull requests

1 participant