-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Birthday format needs to be consistent #8
Comments
Agreed, YYYY-MM-DD is far less ambiguous than MM-DD-YYYY (which where I come from would be interpreted as DD-MM-YYYY). |
Yes same here, great I'll go ahead and implement this, but as it could be a breaking change for some it'll likely need a major version bump. So might want to hold off until it's clear what's happening in terms of unification of the profiles? |
Agreed. I'll hopefully get time next week to have a good think on things. I also need to lint all the repos before we go making too many changes. |
@rwky do you still maintain this package? |
Yep, not worked on unifying profiles lately, promise support has been a higher priority though if you want to add a PR I'll take a look :) |
I suppose either way |
The birthday field in the profile is populated straight form what comes from Facebook.
In this case it's formatted mm/dd/yyyy.
I propose we re-format this to ISO standard format, e.g. YYYY-MM-DD
Can use the following code to achieve this transformation:
The text was updated successfully, but these errors were encountered: