Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to compare pulser versions when abstract repr validation fails #754

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Attempt to compare pulser versions when abstract repr validation fails #754

merged 3 commits into from
Oct 17, 2024

Conversation

HGSilveri
Copy link
Collaborator

@HGSilveri HGSilveri commented Oct 16, 2024 •
edited
Loading

  • In case abstract repr validation fails, attempts to fetch the stored pulser version and compares it with the current one. If the current one is lower, informs the user that the failures might stem from added features in the new version
  • Schema allows the pulser version to be added in top-level serialized objects

@HGSilveri HGSilveri added this to the v1.1 milestone Oct 16, 2024
@HGSilveri HGSilveri marked this pull request as ready for review October 17, 2024 15:12
a-corni
a-corni approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@a-corni a-corni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HGSilveri HGSilveri merged commit c32b4bd into develop Oct 17, 2024
9 checks passed
@HGSilveri HGSilveri deleted the hs/abstract-repr-pulser-version branch October 17, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-corni a-corni a-corni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@HGSilveri @a-corni