Adding register_is_from_calibrated_layout and is_calibrated_layout to Device #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HGSilveri
reviewed
Sep 22, 2023
Comment on lines
575
to
581
| if ( | ||
| isinstance(register, BaseRegister) | ||
| and register._layout_info is None | ||
| ): | ||
| return False | ||
| return self.is_calibrated_layout(cast(RegisterLayout, register.layout)) | ||
|
|
There was a problem hiding this comment.
This will raise an AttributeError when register_layout is not a MappableRegister nor a BaseRegister. I think a TypeError would be more appropriate in that case, so perhaps we can check the type of register_layout first.
HGSilveri
reviewed
Sep 22, 2023
Comment on lines
572
to
573
| if not isinstance(register, BaseRegister) or isinstance( | ||
| register, MappableRegister |
There was a problem hiding this comment.
Suggested change
| if not isinstance(register, BaseRegister) or isinstance( | |
| register, MappableRegister | |
| if not isinstance(register, (BaseRegister, MappableRegister)) |
HGSilveri
approved these changes
Sep 22, 2023
MatthieuMoreau0
approved these changes
Sep 22, 2023
Merged
HGSilveri
added a commit
that referenced
this pull request
Sep 27, 2023
Main changes: e0943d9 Override `optimal_detuning_off` on stored calls (#588) 3e40319 Deprecate legacy serializer + Improve error messages (#585) 9e05982 Adding register_is_from_calibrated_layout and is_calibrated_layout to Device (#586) c08dfa8 Adding dmm config and modulation to sequence (#564) 5270944 Clarify the Conventions in Pulser (#573) 2315989 Give access to all EOM block parameters and allow for phase drift correction (#566) d5ac020 Adding DetuningMap, DMM (#539) f56a19f Remove expired deprecations in pulser-pasqal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @HGSilveri:
Add two new methods to
Device:Device.is_calibrated_layout(layout: RegisterLayout): Checks whether a layout is within the calibrated layouts.Device.register_is_from_calibrated_layout(register: BaseRegister|MappableRegister): Checks whether the register was constructed from a pre-calibrated layout (ie checks if it has a layout ANDis_calibrated_layout(layout))As discussed, returns a boolean and not an error.
register_is_from_calibrated_layout works with BaseRegister (hence Register and Register3D) and MappableRegister (always has a layout in this case) because the type of the register in a sequence can be of type one of these two types.
Closes #577