-
-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated CFlie protocol #723
base: master
Are you sure you want to change the base?
Conversation
…lowing fixed RF channel and bitrate
From what I can see in the release build log, there should be enough space (highest is 98%) to not disable any protocols for this PR. Can you reenable the protocols to check the space? |
Adding the protocols back... |
You were right, just above the limit from a few hundred bytes... |
There might be some unused code for telemetry handling (the telemetry is not working at this point), but not sure how much we can save there. Maybe there is another protocol that is not used much which could be disabled? |
The CI now builds with one _Config.h an idea would be to add e.g. _ConfigObscure.h with less used protocols and another CI run to see to build with those. I indeed would rather see Updated CFlie protocol at the cost of a default less use protocol. Note that the disabled by default protocol would still be available for users, they just need to make their own _MyConfig.h, compile and flash that to their 4in1. There are likely better solutions but for now, comment out a less used protocol in the _Config.h IMHO. I would vote for FrSkyV >;-) |
There are a lot of maple libraries links in that are not use e.g. IPAdress.* and i2c* ino core.a a quick removal of these we went from |
Is this protocol really still being in use? |
Yes indeed, and a lot and a lot more soon likely, see https://www.bitcraze.io/products/crazyflie-bolt-1-1/ I just came across this issue and since I know the https://flapper-drones.com/wp/ and was just busy updating and adding _My_Config.h to all of my 4in1 modules and in process of re-flasing and testing dozen or so TX's from OpenTX to EDGE TX internal modules to 1.3.3.20 a good chance to see where we could minimize the ROM size, since it seems a big thing if more space would be available. BTW I do have a Crazyflie to test even. Even if the outcome would be a good way to "create" more space for the 4in1, that would not be to bad don't you think? ;) Thanks for asking. |
As @OpenUAS says, we are using it on the Flapper drones (powered by the Crazyflie Bolt board), that we produce. |
@OpenUAS I was not aware that it was still in use. And yes for sure I'll take any space saving. |
@pascallanger Thanks for the compliments :) @OpenUAS has access to both a Crazyflie and one of our Flappers for testing. Would that do for now? We might be able to send you a testing platform later, can you send me an email to [email protected]? |
Found some time today... Sketch uses 120400 bytes (99%) of program storage space. Maximum is 120808 bytes via compiler.cpp.extra_flags=-fshort-enums -fshort-wchar -flto , no rejoicing yet, still needs testing specifically -fshort-enums effect. |
7bffa17
to
7e671b9
Compare
@OpenUAS have you got any more updates on this? Happy to take a look at integrating/implementing whatever you have so far. |
This PR improves the CFlie protocol:
1) Switching to crtp_cppm_emu packets instead of crtp_rpyt packets
2) Enabling to set a fixed data rate and rf channel in OpenTX/Edge TX menu for flying with multiple Crazyflies and Transmitters simultaneously
Tested with the following Crazyflie drones and flight controllers using JumperRC T-Lite 4-in-1 and Jumper RC T-Pro 4-in-1:
Disabled protocols such that CFlie fits in the memory (to be discussed):