Skip to content
This repository has been archived by the owner on May 12, 2020. It is now read-only.

copied libraries contain a .h file that prevents compiling #195

Open
cmsunu28 opened this issue Mar 9, 2017 · 3 comments
Open

copied libraries contain a .h file that prevents compiling #195

cmsunu28 opened this issue Mar 9, 2017 · 3 comments
Assignees

Comments

@cmsunu28
Copy link

cmsunu28 commented Mar 9, 2017

Copying a library in dev creates a structure with a second .h file nested in a folder. This throws an error as a default and prevents the library from compiling until it is removed.

Copy library
screen shot 2017-03-09 at 9 02 54 am

Won't compile immediately after, no edits to library or anything
screen shot 2017-03-09 at 9 03 14 am

Here's the problem
screen shot 2017-03-09 at 9 03 33 am

Deleted that .h and moved the other library files inside
screen shot 2017-03-09 at 9 03 55 am

@m-mcgowan
Copy link
Contributor

Thanks for the detailed description and screen grabs.

The nested includes are "adapters" that support legacy applications using the #include "LibraryName/LibraryName.h" syntax. They are meant to be there, and shouldn't cause an issue themselves if the rest of the library is also present.

The actual header file from the library should exist in the src folder of the library, but from the screenshot, it looks like that it's missing.

@m-mcgowan
Copy link
Contributor

I just tried this and was unable to replicate the directory structure above. This is what I get after copying the library:

dev_issue195

I'm not sure how to explain the difference:

  • are we using the same version of particle-dev-libraries? I'm on 0.2.18
  • Is there any chance you may have dragged those files from src into the Adafruit_MLX90614 subfolder? In your screenshot, there are two files in the subfolder, where there should only be one.

@ScruffR
Copy link

ScruffR commented Jun 8, 2017

The parallel issue is already confirmed, so I guess this should be too
particle-iot-archived/particle-dev-libraries#26

@suda suda added the bug label Jul 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants