-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve: UX and DX in delete and reset modals #382
Merged
nitisht
merged 33 commits into
parseablehq:main
from
pranavgoel29:ux-improvement-delete-modal
Nov 28, 2024
Merged
Improve: UX and DX in delete and reset modals #382
nitisht
merged 33 commits into
parseablehq:main
from
pranavgoel29:ux-improvement-delete-modal
Nov 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… isProcessing optional
…l and added jsdocs
…ocessing information
…confirmation logic
…ge Cancel button in DeleteIngestorModal
…t password functionality, and update placeholder texts for better clarity
…dal and related components
… in RoleTR component
pranavgoel29
changed the title
UX improvement delete modal
UX and DX improvement in delete or reset modals
Nov 23, 2024
pranavgoel29
changed the title
UX and DX improvement in delete or reset modals
Improve: UX and DX in delete and reset modals
Nov 23, 2024
praveen5959
requested changes
Nov 27, 2024
praveen5959
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
nikhilsinhaparseable
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #381
This update is all about the new
DeleteOrResetModal
component, built to make delete and reset actions simpler and more consistent. It’s a reusable modal that keeps things uniform across the app UI and comes with handy features like confirmation text and an optional processing state.New Component Introduction:
src/components/Misc/DeleteOrResetModal.tsx
: Added a newDeleteOrResetModal
component to handle delete and reset actions with confirmation text and optional processing state. (with proper JSDocs 😎)src/components/Misc/styles/DeleteOrResetModal.module.css
: Added new CSS styles for theDeleteOrResetModal
component.Modals updated:
Other fixes:
selectedRole
andselectStream
state value var naming inRoleTR.tsx
andPrivilegeTR.tsx
respectively.Before:
After: