Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve: UX and DX in delete and reset modals #382

Merged
merged 33 commits into from
Nov 28, 2024

Conversation

pranavgoel29
Copy link
Contributor

@pranavgoel29 pranavgoel29 commented Nov 23, 2024

Resolves #381

This update is all about the new DeleteOrResetModal component, built to make delete and reset actions simpler and more consistent. It’s a reusable modal that keeps things uniform across the app UI and comes with handy features like confirmation text and an optional processing state.

New Component Introduction:

  • src/components/Misc/DeleteOrResetModal.tsx: Added a new DeleteOrResetModal component to handle delete and reset actions with confirmation text and optional processing state. (with proper JSDocs 😎)
  • src/components/Misc/styles/DeleteOrResetModal.module.css: Added new CSS styles for the DeleteOrResetModal component.

Modals updated:

  • Roles section
    • Delete Role modal
    • Remove roles privilege
  • Users section
    • Complete user delete modal
    • User role privilege removal
    • Reset user password
  • Delete a tile modal updates from a dashboard.
  • Fixed button order and styling in the Ingestor Deletion modal.

Other fixes:

  • Fixed selectedRole and selectStream state value var naming in RoleTR.tsx and PrivilegeTR.tsx respectively.
  • Renamed 'data-itemId' to 'data-itemid' to resolve react prop warning.

Before:

image image image

After:

image image image

…t password functionality, and update placeholder texts for better clarity
@pranavgoel29 pranavgoel29 marked this pull request as draft November 23, 2024 19:13
@pranavgoel29 pranavgoel29 marked this pull request as ready for review November 23, 2024 19:45
@pranavgoel29 pranavgoel29 changed the title UX improvement delete modal UX and DX improvement in delete or reset modals Nov 23, 2024
@pranavgoel29 pranavgoel29 changed the title UX and DX improvement in delete or reset modals Improve: UX and DX in delete and reset modals Nov 23, 2024
src/pages/AccessManagement/PrivilegeTR.tsx Outdated Show resolved Hide resolved
src/components/Misc/DeleteOrResetModal.tsx Outdated Show resolved Hide resolved
src/pages/Stream/components/DeleteStreamModal.tsx Outdated Show resolved Hide resolved
src/components/Misc/DeleteOrResetModal.tsx Show resolved Hide resolved
src/components/Misc/DeleteOrResetModal.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@praveen5959 praveen5959 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@nitisht nitisht merged commit e6d532f into parseablehq:main Nov 28, 2024
3 of 4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance UX for Delete and Reset Modals
4 participants