-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added filter_query to filter builder #355
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koustavd18
requested changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filter_query should not be optional field for createSavedFilterType
Koustavd18
requested changes
Nov 5, 2024
Koustavd18
requested changes
Nov 6, 2024
Koustavd18
previously approved these changes
Nov 6, 2024
nikhilsinhaparseable
previously approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to merge
github-actions
bot
dismissed stale reviews from nikhilsinhaparseable and Koustavd18
via
November 7, 2024 09:29
07e8278
praveen5959
force-pushed
the
filter_query
branch
from
November 7, 2024 10:50
3c32f47
to
3d1fdf6
Compare
Koustavd18
approved these changes
Nov 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
filter_query
to all types of filters.Testing Scenarios:
Current Behavior: The query is applied but it shows filter type as SQL
Expected Behavior: The query should be applied with appropriate filter type view in the filter section.
Current Behavior: filter_builder is being sent in the payload.
Expected Behavior:
filter_builder
will not be sent, insteadfilter_query
will have the query.Current Behavior:
filter_builder
is being sent in the payload.Expected Behavior:
filter_builder
will not be sent, insteadfilter_query
will have the query.Current Behavior: The filter query is applied but it always shows the filter view as SQL mode.
Expected Behavior: The filter should be applied as per the filter type and the respective view should be showed in the filter bar.
Current Behavior:
filter_builder
field is sent as per thefilter_type
in the PUT callExpected Behavior:
filter_builder
field will not be sent in the PUT callExpected Behavior: A new URL query parameter should be added to represent
filter_type
when a filter is applied, to track and maintain the filter type within the URL.