You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The delegate locking mechanism is no longer needed or useful now that we target a contract instead of a code hash with a delegate call.
The locking system adds a bunch of complexity for questionable benefit. While it is true that we could change the locking mechanism to lock another contract. What about set_code_hash? Should it also prevent changing the code hash? It would make that feature useless if anyone could prevent you from upgrading your code.
A (delegate) call is already a fallible operation. Making it fail because the code was deleted doesn't change that. People just need to be careful what they delegate into. Probably avoiding upgradeable or terminateable contracts.
This should be done for the minimal feature launch because it requires storage changes (removing the delegate dependencies from a contract).
The text was updated successfully, but these errors were encountered:
The delegate locking mechanism is no longer needed or useful now that we target a contract instead of a code hash with a delegate call.
The locking system adds a bunch of complexity for questionable benefit. While it is true that we could change the locking mechanism to lock another contract. What about
set_code_hash
? Should it also prevent changing the code hash? It would make that feature useless if anyone could prevent you from upgrading your code.A (delegate) call is already a fallible operation. Making it fail because the code was deleted doesn't change that. People just need to be careful what they delegate into. Probably avoiding upgradeable or terminateable contracts.
This should be done for the minimal feature launch because it requires storage changes (removing the delegate dependencies from a contract).
The text was updated successfully, but these errors were encountered: