Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revive: Remove delegate locking mechanism #7092

Open
athei opened this issue Jan 8, 2025 · 0 comments · May be fixed by #7230
Open

revive: Remove delegate locking mechanism #7092

athei opened this issue Jan 8, 2025 · 0 comments · May be fixed by #7230
Assignees

Comments

@athei
Copy link
Member

athei commented Jan 8, 2025

The delegate locking mechanism is no longer needed or useful now that we target a contract instead of a code hash with a delegate call.

The locking system adds a bunch of complexity for questionable benefit. While it is true that we could change the locking mechanism to lock another contract. What about set_code_hash? Should it also prevent changing the code hash? It would make that feature useless if anyone could prevent you from upgrading your code.

A (delegate) call is already a fallible operation. Making it fail because the code was deleted doesn't change that. People just need to be careful what they delegate into. Probably avoiding upgradeable or terminateable contracts.

This should be done for the minimal feature launch because it requires storage changes (removing the delegate dependencies from a contract).

@athei athei converted this from a draft issue Jan 8, 2025
@athei athei changed the title Remove delegate locking mechanism revive: Remove delegate locking mechanism Jan 8, 2025
@athei athei self-assigned this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Minimal Feature Launch
1 participant