Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the Node version change to fix electron builder #1388

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

lyonsil
Copy link
Member

@lyonsil lyonsil commented Dec 11, 2024

Only on Windows, the latest updates seem to break the publish step in our GitHub workflows. I think this started with the change that included updating Node, so trying to back this out to see if that fixes the problem.


This change is Reviewable

Copy link
Contributor

@irahopkinson irahopkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: thanks for noticing the build issue

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lyonsil lyonsil merged commit d795f89 into main Dec 11, 2024
7 checks passed
@lyonsil lyonsil deleted the change-node-version-back branch December 11, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants