Skip to content
This repository has been archived by the owner on Nov 22, 2021. It is now read-only.

Fallback emojis can not be used to operate the MultiPageMenu #71

Open
parafoxia opened this issue Oct 3, 2020 · 1 comment
Open

Fallback emojis can not be used to operate the MultiPageMenu #71

parafoxia opened this issue Oct 3, 2020 · 1 comment
Labels
bug Something isn't working clone issue Only an issue on cloned or forked instances of Solaris

Comments

@parafoxia
Copy link
Owner

This may be the for every menu, but it's not been tested yet.
@parafoxia parafoxia added bug Something isn't working clone issue Only an issue on cloned or forked instances of Solaris labels Oct 3, 2020
@bradykelly
Copy link

I have found the bug. Class Selector uses emoji.name to determine which emoji was clicked, but the fallback emojis are all strings, and str has no name attribute, so an error occurs when a fallback emoji is clicked. I have replaced emoji.name with function get_emoji_name and will complete my pull request later today.

bradykelly added a commit to bradykelly/Solaris that referenced this issue Oct 7, 2020
@bradykelly
Issue parafoxia#71: Fixed fallback emojis on Selector class
11eeeb4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working clone issue Only an issue on cloned or forked instances of Solaris
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bradykelly @parafoxia