refactor: replace extra fields with ExecutionPayloadSidecar in engine
#11901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
added
C-debt
onbjerg
force-pushed
the
onbjerg/exec-payload-sidecar
branch
from
38e3089 to
2cb12ef
Compare
onbjerg
changed the title
ExecutionPayloadSidecar in engineExecutionPayloadSidecar in engine
onbjerg
added
the
S-blocked
|
This is blocked, |
onbjerg
force-pushed
the
onbjerg/exec-payload-sidecar
branch
from
2cb12ef to
ffb777a
Compare
onbjerg
added
S-blocked
|
Blocked by Alloy release and alloy-rs/op-alloy#178 Edit: Not actually blocked |
onbjerg
force-pushed
the
onbjerg/exec-payload-sidecar
branch
5 times, most recently
from
5d289a7 to
8735ca1
Compare
onbjerg
requested review from
mattsse,
Rjected,
emhane,
rkrasiuk,
fgimenez and
gakonst
as code owners
onbjerg
force-pushed
the
onbjerg/exec-payload-sidecar
branch
from
8735ca1 to
dc9d048
Compare
onbjerg
removed
the
S-blocked
mattsse
approved these changes
Oct 23, 2024
Comment on lines
+80
to
+85
| "reth-chainspec", | ||
| "reth-primitives/optimism", | ||
| "reth-provider/optimism", | ||
| "reth-blockchain-tree/optimism", | ||
| "reth-db/optimism", | ||
| "reth-db-api/optimism", |
| @@ -439,11 +419,16 @@ where | |||
|
|
|||
| Ok(( | |||
| block_to_payload(reorg_block), | |||
| // todo(onbjerg): how do we support execution requests? | |||
There was a problem hiding this comment.
meh, good question, lets track?
onbjerg
force-pushed
the
onbjerg/exec-payload-sidecar
branch
2 times, most recently
from
4dfe699 to
cae526e
Compare
onbjerg
force-pushed
the
onbjerg/exec-payload-sidecar
branch
from
cae526e to
7c9f2f3
Compare
mattsse
approved these changes
Oct 23, 2024
This was referenced Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #11865
Replaces the hack to add execution requests throughout the engine + engine interceptor components with the new
ExecutionPayloadSidecarintroduced in alloy-rs/alloy#1517. TheExecutionPayloadSidecarreplaces both Prague and Cancun fields.This also finishes Prague integration in most of the engine interceptors, but does not adjust a lot of the testing code we have to support execution requests.