Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection tests skipped in PHP 7 #169

Open
danielbachhuber opened this issue Feb 17, 2017 · 1 comment
Open

Fix connection tests skipped in PHP 7 #169

danielbachhuber opened this issue Feb 17, 2017 · 1 comment
Labels

Comments

@danielbachhuber
Copy link
Contributor

In f638c97, I skipped a couple of tests that fail in PHP 7.

Example failed build https://travis-ci.org/pantheon-systems/wp-redis/builds/202458492

PHP 7.1

1) CacheTest::test_redis_reload_force_cache_flush
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'WP Redis: Redis server went away'
+''

PHP 7.0

1) CacheTest::test_redis_reload_force_cache_flush
Redis::connect(): connect() failed: Connection refused
/home/travis/build/pantheon-systems/wp-redis/tests/phpunit/test-cache.php:109
2) CacheTest::test_redis_bad_authentication
Redis::connect(): connect() failed: Connection refused

It seems like the source of these errors is in the underlying phpredis library.

I wasn't able to reproduce the PHP 7.0 error locally until I updated to phpredis 3.1.1 (https://github.com/Homebrew/homebrew-php/pull/3997), then I tried fixing it with 21963e4 which resulted in segfaults on Travis.

@danielbachhuber
Copy link
Contributor Author

d4cbcea is another test that's now skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant