Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to make sure or force multidev labels to be lowercase? #409

Open
ccharlton opened this issue Oct 9, 2021 · 3 comments
Open
Labels

Comments

@ccharlton
Copy link
Contributor

Is a strtolower() call necessary to make sure the environment name is lowercase, or is that already taken care of by the system?

@greg-1-anderson
Copy link
Member

In typical use, build:env:create will always be called with an env name like "pr-123"; however, it is possible for this command to be used in home-grown scripts, so it's possible that the env name could be anything. An strtolower couldn't hurt.

@ccharlton
Copy link
Contributor Author

Could I get clarification on where label is used or appears in our Dashboard?

@greg-1-anderson
Copy link
Member

Presuming we have a site 'brisbanoween' with a multidev named '2020', e.g.:

https://admin.dashboard.pantheon.io/sites/509b23b4-12db-4cbf-880e-f97872418127#2020

Then if you visit that multidev site:

https://2020-brisbanoween.pantheonsite.io
        ^^^^
        $env_label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants