Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing secrets.json credential overlap or confusion #151

Open
ccharlton opened this issue Oct 17, 2018 · 0 comments
Open

Reducing secrets.json credential overlap or confusion #151

ccharlton opened this issue Oct 17, 2018 · 0 comments

Comments

@ccharlton
Copy link
Collaborator

I noticed while adding the Diffy Visual Regression Quicksilver script, that username is quite generic. Now, I know for myself, I can change that username secret key in the PHP file to something like diffy_username but I'm not sure if others get that. So, if the key username is used for all script examples, do you think any customers will take pause because they already may have that key used in their secrets file (and not realize it's trivial to update the key accessed in secrets.json)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant