-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make 8.x checks a parameter of the action #8
Comments
I assume @kporras07's intention was to not have the "stable" branch of the action point to an unstable version of the PHPCompatibility project, but since we're at 4+ years since a release, it's likely the right choice to just default to using the |
Yeah, also I think I initially didn't notice that you needed dev to get those versions. I'm happy with the decision that @pwtyler makes here :) |
It will be easier to make develop the default state rather than trying to parameterize using the development version or not. With 7.4 long-EOL, I expect the vast majority of use cases will be PHP 8+, so will just be making the "breaking" change. |
Instead of using an @dev branch whose only difference is using an unreleased version of the upstream, make the option for 8.x checks an input parameter of running the action
The text was updated successfully, but these errors were encountered: