-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate ODGI as a submodule into the repository? #3
Comments
I was hoping that we could have a conda/pip install of ODGI and have dependency management be done that way. |
That sounds even better :) |
I don't know how to get the build for odgi to work within pip or conda. Would be happy to help but someone else with more experience should lead. |
As far as I know, a pure C++ project like odgi won't work on pip but we can bring it to conda, of course. |
@JervenBolleman I am not sure, what the plan will be. Do we just want be able to install odgi via conda and integrate it via a command line call? |
We definitely want to continue with the python bindings that @ekg did. At scale the cost of reloading the same graph from disk over and over will be to high with cli. So me also not being the python hero, would like to see a way that conda can put the C++/python module lib directly on the python path. Basically it should be as standard as possible so a conda install away would be best. |
I have to admit I never ran into the case where one wants to make a C++/Python module library available on Conda. But I will ask some people who might have. |
I was thinking of pytorch as the canonical example of having C/C++ in conda. |
Jumping right in here and having added quite some tools to Bioconda / conda-forge recently: It will be definitely possible to have both odgi and the spodgi tool(s) in bioconda as they both work on genome graphs which is a (computational) biology domain so to say. I can help in getting this done, but ideally, there should be a release of both projects on Github first, that one can refer to directly with a URL (see here on how to do that). Once this is done, @subwaystation and I can take care of the bioconda recipes for both odgi and spodgi. Also, if you need more recipes within the project(s) here, let me know and I can help on that. Planning to use your stuff at some point, so getting in touch sounds like a win-win for everyone here :-) |
@JervenBolleman If you have time, you can take a look at pangenome/odgi#75 (comment). |
As the tool will heavily rely on ODGI, would it make sense to integrate it as a submodule into the repository?
The text was updated successfully, but these errors were encountered: