Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Missing type hint for squeeze method #60384

Closed
1 task done
JessJohn0 opened this issue Nov 21, 2024 · 1 comment · Fixed by #60415
Closed
1 task done

DOC: Missing type hint for squeeze method #60384

JessJohn0 opened this issue Nov 21, 2024 · 1 comment · Fixed by #60415
Labels
Typing type annotations, mypy/pyright type checking

Comments

@JessJohn0
Copy link

Pandas version checks

  • I have checked that the issue still exists on the latest versions of the docs on main here

Location of the documentation

https://github.com/pandas-dev/pandas/blob/main/pandas/core/generic.py

Documentation problem

The squeeze method is missing a type hint.

Suggested fix for documentation

Adding a type hint to the squeeze method to be consistent with the rest of the code.
@JessJohn0 JessJohn0 added Docs Needs Triage Issue that has not been reviewed by a pandas team member labels Nov 21, 2024
@KevsterAmp
Copy link
Contributor

Can confirm, specifically this line:

pandas/pandas/core/generic.py

Line 841 in 1c986d6

def squeeze(self, axis: Axis | None = None):

@asishm asishm added the Typing type annotations, mypy/pyright type checking label Nov 21, 2024
@rhshadrach rhshadrach removed Needs Triage Issue that has not been reviewed by a pandas team member Docs labels Nov 21, 2024
@jasonmokk jasonmokk mentioned this issue Nov 25, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DOC: Add type hint for squeeze method jasonmokk/pandas
4 participants
@asishm @rhshadrach @KevsterAmp @JessJohn0