Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Series.rename_axis and DataFrame.rename_axis typing #1048

Merged
merged 8 commits into from
Nov 22, 2024

Conversation

dpoznik
Copy link
Contributor

@dpoznik dpoznik commented Nov 21, 2024

Note that the four failing tests also fail on main and are unrelated to these changes:

FAILED tests/test_series.py::test_astype_float['f16'-<class 'numpy.longdouble'>] - TypeError: data type 'f16' not understood
FAILED tests/test_series.py::test_astype_float['float128'-<class 'numpy.longdouble'>] - TypeError: data type 'float128' not understood
FAILED tests/test_series.py::test_astype_complex['c32'-<class 'numpy.clongdouble'>] - TypeError: data type 'c32' not understood
FAILED tests/test_series.py::test_astype_complex['complex256'-<class 'numpy.clongdouble'>] - TypeError: data type 'complex256' not understood

@loicdiridollou
Copy link
Contributor

loicdiridollou commented Nov 21, 2024

Are you working on Mac?

Those tests fail on arm64 Mac if I am not wrong because those types are not defined, this is fine. The workflow relies on Mac not arm so once the workflows are kicked off you will see that all tests pass.

docs/setup.md Outdated Show resolved Hide resolved
pandas-stubs/core/frame.pyi Show resolved Hide resolved
pandas-stubs/core/series.pyi Show resolved Hide resolved
pandas-stubs/core/series.pyi Show resolved Hide resolved
pandas-stubs/core/series.pyi Show resolved Hide resolved
@dpoznik
Copy link
Contributor Author

dpoznik commented Nov 22, 2024

Are you working on Mac?

Yes

Those tests fail on arm64 Mac if I am not wrong because those types are not defined, this is fine. The workflow relies on Mac not arm so once the workflows are kicked off you will see that all tests pass.

OK, great. Thanks for the heads-up.

@dpoznik dpoznik marked this pull request as ready for review November 22, 2024 00:00
tests/test_frame.py Outdated Show resolved Hide resolved
docs/setup.md Outdated Show resolved Hide resolved
pandas-stubs/core/frame.pyi Show resolved Hide resolved
pandas-stubs/core/series.pyi Show resolved Hide resolved
tests/test_frame.py Outdated Show resolved Hide resolved
tests/test_series.py Outdated Show resolved Hide resolved
@dpoznik
Copy link
Contributor Author

dpoznik commented Nov 22, 2024

@loicdiridollou and @Dr-Irv, thanks for you reviews. I believe I have addressed all your comments.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dpoznik

@Dr-Irv Dr-Irv merged commit d289ef5 into pandas-dev:main Nov 22, 2024
10 checks passed
@dpoznik dpoznik deleted the fix-rename_axis branch November 22, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Series.rename_axis(None) not accepted
3 participants