-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Series.rename_axis
and DataFrame.rename_axis
typing
#1048
Conversation
Are you working on Mac? Those tests fail on arm64 Mac if I am not wrong because those types are not defined, this is fine. The workflow relies on Mac not arm so once the workflows are kicked off you will see that all tests pass. |
Yes
OK, great. Thanks for the heads-up. |
@loicdiridollou and @Dr-Irv, thanks for you reviews. I believe I have addressed all your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dpoznik
Series.rename_axis(None)
not accepted #1042Note that the four failing tests also fail on
main
and are unrelated to these changes: