Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add Zeal as a supported wallet #8727

Open
1 task done
Nicvaniek opened this issue Jan 2, 2024 · 12 comments
Open
1 task done

[Feature Request] Add Zeal as a supported wallet #8727

Nicvaniek opened this issue Jan 2, 2024 · 12 comments
Assignees
Labels
Feature Request New feature or request Triage Awaiting team acknowledgement

Comments

@Nicvaniek
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem you are facing?

Many Zeal wallet users use pancake swap and are having difficulties connecting due to having to select the "Injected" option. Clicking on Metamask like on other dApps does not work in this case (I have not dug very deep into the code, but assuming there is a different connector in use).

Describe the solution you'd like

Would be nice if there was a dedicated Zeal option (similar to Rabby) that users can select if Zeal is installed. I have tested the change locally and it works fine, but wanted to create this issue before making a PR in case anyone wants to discuss the proposal. I would probably also need assistance to get the Zeal icon added to the CDN?

How does this feature benefit PancakeSwap users and CAKE holders?

If they use Zeal wallet, they will have a much improved UX when using pancake swap. Their wallet of choice will show up as a first-class citizen when interacting with the UI.

Anything else?

image
image

@Nicvaniek Nicvaniek added Feature Request New feature or request Triage Awaiting team acknowledgement labels Jan 2, 2024
@Nicvaniek
Copy link
Author

Nicvaniek commented Jan 2, 2024

Seems like I don't have permissions to push a new branch, so help from someone here would be appreciated. Below is the code snippet to be added to apps/web/src/config/wallet.ts:

{
      id: 'zeal',
      title: 'Zeal',
      icon: `${ASSET_CDN}/web/wallets/zeal.png`,
      get installed() {
        return typeof window !== 'undefined' && Boolean(window.ethereum?.isZeal)
      },
      connectorId: ConnectorNames.Injected,
      guide: {
        desktop: 'https://docs.zeal.app/getting-started-with-zeal',
      },
      downloadLink: {
        desktop: 'https://chromewebstore.google.com/detail/zeal-wallet/heamnjbnflcikcggoiplibfommfbkjpj',
      },
},

Where zeal.png is the below image:

Zeal_Logo

@Nicvaniek
Copy link
Author

@chef-jojo

@Surya-Git-hub
Copy link

Hi @Nicvaniek just wanted to know, is it possible to encrypt or decrypt data using passkeys when using webauthn APIs, if yes, can you suggest how it can be done.

@Hitosaw
Copy link

Hitosaw commented Jan 13, 2024

{
id: 'zeal',
title: 'Zeal',
icon: ${ASSET_CDN}/web/wallets/zeal.png,
get installed() {
return typeof window !== 'undefined' && Boolean(window.ethereum?.isZeal)
},
connectorId: ConnectorNames.Injected,
guide: {
desktop: 'https://docs.zeal.app/getting-started-with-zeal',
},
downloadLink: {
desktop: 'https://chromewebstore.google.com/detail/zeal-wallet/heamnjbnflcikcggoiplibfommfbkjpj',
},
},

1 similar comment
@Hitosaw
Copy link

Hitosaw commented Jan 13, 2024

{
id: 'zeal',
title: 'Zeal',
icon: ${ASSET_CDN}/web/wallets/zeal.png,
get installed() {
return typeof window !== 'undefined' && Boolean(window.ethereum?.isZeal)
},
connectorId: ConnectorNames.Injected,
guide: {
desktop: 'https://docs.zeal.app/getting-started-with-zeal',
},
downloadLink: {
desktop: 'https://chromewebstore.google.com/detail/zeal-wallet/heamnjbnflcikcggoiplibfommfbkjpj',
},
},

@PancakeSwap-bot
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 2 days.

6 similar comments
@PancakeSwap-bot
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 2 days.

@PancakeSwap-bot
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 2 days.

@PancakeSwap-bot
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 2 days.

@PancakeSwap-bot
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 2 days.

@PancakeSwap-bot
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 2 days.

@PancakeSwap-bot
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 2 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request Triage Awaiting team acknowledgement
Projects
None yet
Development

No branches or pull requests

5 participants