Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh to match pallets #386

Merged
merged 3 commits into from
Nov 18, 2024
Merged

refresh to match pallets #386

merged 3 commits into from
Nov 18, 2024

Conversation

davidism
Copy link
Member

@davidism davidism commented Nov 16, 2024

Refresh all project layout, tools, and configurations to match the standard Pallets project layout. It'll be easier to review only the first commit 0d63747, the other two commits are ruff and mypy.

It looks like a lot of code changes, but it's all down to the following style/typing changes only:

  • We use a 1 import per line style, rather than the multi/tuple style.
  • We use Black's standard 88 character line length.
  • Updating mypy removed some ignores
  • Changing try/except ImportError to if sys.version_info checks for typing extensions seemed to make some checks about ParamSpec take effect that were being treated as Any before.

Here's all the changes:

  • use flit as build backend
  • pin development dependencies using pip-compile
  • stop using dependabot
  • update tox envs and requirements
  • add tox envs for updating pins in actions, pre-commit, and pip-compile
  • use ruff for linting and formatting
  • transfer copyright to pallets
  • use global code of conduct
  • convert readme to markdown
  • new contributing guide
  • update issue templates
  • add .editorconfig
  • update .gitignore
  • add license and changes to docs
  • simplify docs config
  • add myst parser in preparation for markdown docs
  • remove license for previous logo
  • apply ruff lint and format
  • fix mypy findings

I've started experimenting with uv, and added a few uses here. Later, after I experiment more, we can go all in by using uv lock to manage environments with dependency groups, and using setup-uv in CI.

  • added tox-uv instead of virtualenv
  • used uv pip compile instead of pip-compile from pip-tools

@davidism davidism added this to the 0.20.0 milestone Nov 16, 2024
- use flit as build backend
- pin development dependencies using pip-compile
- stop using dependabot
- update tox envs and requirements
- add tox envs for updating pins in actions, pre-commit, and pip-compile
- use ruff for linting and formatting
- transfer copyright to pallets
- use global code of conduct
- convert readme to markdown
- new contributing guide
- update issue templates
- add .editorconfig
- update .gitignore
- add license and changes to docs
- simplify docs config
- add myst parser in preparation for markdown docs
- remove license for previous logo
@davidism davidism merged commit 171c4a7 into main Nov 18, 2024
10 checks passed
@davidism davidism deleted the refresh branch November 18, 2024 18:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants