Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global failures meter #636

Open
jkozlowski opened this issue Feb 26, 2020 · 1 comment
Open

Global failures meter #636

jkozlowski opened this issue Feb 26, 2020 · 1 comment

Comments

@jkozlowski
Copy link
Contributor

What happened?

Both MetricsInvocationEventHandler and TaggedMetricsServiceInvocationEventHandler use the same metric name, but potentially different metric registries (dropwizard MetricRegistry vs TaggedMetricRegistry). Depending on how metrics are reported from those 2, I believe there's a potential that the numbers reported to monitoring infra are non-deterministic?

What did you want to happen?

https://github.com/palantir/atlasdb has those classes somewhat copied, and therefore suffers from the same issue. I am curious what the correct behavior here should be.
@jkozlowski
Copy link
Contributor Author

@carterkozak @iamdanfox for SA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jkozlowski