improvement: WithAllowCreateWithEmptyURIs() suppresses errors due to empty URIs in NewClient() #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…empty URIs in NewClient()
|
I extracted some unrelated changes into #697 |
bmoylan
commented
Sep 27, 2024
| @@ -477,11 +477,7 @@ func newValidatedClientParamsFromConfig(ctx context.Context, config ClientConfig | |||
| } | |||
| uris = append(uris, uriStr) | |||
| } | |||
| // Plain HTTP clients do not store URIs | |||
| if !isHTTPClient && len(uris) == 0 { | |||
| return refreshingclient.ValidatedClientParams{}, werror.ErrorWithContextParams(ctx, "httpclient URLs must not be empty") | |||
There was a problem hiding this comment.
This is the bug fix -- this check was too early. It should be possible to "fix" the empty config with WithBaseURLs(...) or a variant, but in that case this would still fail because it operates only on the original ClientConfig struct.
andybradshaw
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was impossible to create a client using refreshable URIs that are currently empty but may not be empty in the future. To handle this case but preserve the general validating behavior, this PR adds a new client option to explicitly allow empty URIs during client creation.
In the case URIs are empty at request time, an error is returned before any request is produced.
This is a prerequisite to implementing a commonly-requested feature in Witchcraft Go Server to mimic Dialogue's
Client<T>that exposes anIsConfigured() boolmethod.This change is