Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Layer Reuse criteria #108

Open
3 tasks
fg-j opened this issue Feb 25, 2021 · 4 comments
Open
3 tasks

Document Layer Reuse criteria #108

fg-j opened this issue Feb 25, 2021 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@fg-j
Copy link

fg-j commented Feb 25, 2021

What happened?

  • What were you attempting to do?
    I wanted to quickly understand what criteria the yarn-install buildpack uses to decide if it'll reuse the cached node_modules layer.

  • What did you expect to happen?
    I expected to find this documented either in the README for the buildpack or somewhere in the Nodejs section of the Docs site.

  • What was the actual behavior? Please provide log output, if possible.
    There's no documentation that I could find, anywhere, of the layer reuse criteria for any of the buildpacks.

Checklist

  • I have included log output.
  • The log output includes an error message.
  • I have included steps for reproduction.
@fg-j
Copy link
Author

fg-j commented Feb 25, 2021

@ekcasey Is this documented for any of the Java buildpacks? Do you think this should be documented? If so, where? (I recall you hoping for some sort of Paketo buildpacks reference docs in the future.)

@kvedurmu
Copy link
Member

kvedurmu commented Apr 7, 2021

@fg-j since it seems like this is a Node.js specific request, could we move this issue into a Node.js repo so that one of the maintainers can get visibility?

@fg-j
Copy link
Author

fg-j commented Apr 7, 2021

cc @arjun024 @thitch97

@kvedurmu I'd rather leave it here since, ultimately, the markdown for these docs live in this repo (for now).

@ekcasey
Copy link
Member

ekcasey commented Apr 13, 2021

@fg-j this isn't currently documented for the Java buildpacks. I agree that this level of detail would be nice to include in future reference docs

cc @dmikusa-pivotal

@andymoe andymoe added the documentation Improvements or additions to documentation label Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants