Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interface for layer contributor to also contribute process types #349

Open
dmikusa opened this issue Jul 5, 2024 · 2 comments
Open
Labels
type:enhancement A general enhancement v2 Work for v2 release

Comments

@dmikusa
Copy link
Contributor

dmikusa commented Jul 5, 2024

Describe the Enhancement

As a layer contributor, I can't presently set process types. That can only happen in the build func. Enable a layer contributor to set process types, so that logic can move out of build into the layer contributors which often are the ones with the most knowledge about the command to run.

This should be optional though. If the layer contributor does not want to contribute processes, that's OK. If the layer contributor doesn't have enough information to set the process types, that's OK too, and they should still be possible to be set in the build func.

Motivation

In simple cases, which is where layer contributor excels the layer contributor can contribute a process type and then the logic for this is more cleanly separated in the layer contributor versus in the build func.

@dmikusa dmikusa added type:enhancement A general enhancement v2 Work for v2 release labels Jul 5, 2024
@loewenstein-sap
Copy link

@dmikusa is this labeled v2 because it is likely to be breaking? Can we consider if this could also be done after a v2 release, even if this might add a little extra for a backward compatible implementation?

@dmikusa
Copy link
Contributor Author

dmikusa commented Nov 8, 2024

This definitely has to happen before a v2 release. We've wanted to do this for a while, but there's no way without breaking API compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement A general enhancement v2 Work for v2 release
Projects
None yet
Development

No branches or pull requests

2 participants