-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
including newrelic buildpack #795
Comments
Long term yes. Short term, there is a problem preventing this. The Paketo builders have a lot of layers to them, so many that we are getting close to the hard limit supported by Docker. We're not adding them now, because of this hard limit. There is some work that needs to be done to squash down the layers on the builder and when that is done we will add in all of the APM related buildpacks. |
In meanwhile, whats your recommendations.... Shall we create our own custom builder with buildpacks that we need ? |
The documented process right now is a custom build command.
By putting the Paketo Java buildpack first, then the APM buildpack you want to use (you can substitute any of them for skywalking in the example above) it let's the normal build happen and then the APM buildpack runs last, which works fine for the APM buildpacks. https://paketo.io/docs/howto/app-monitor/#apm-buildpacks-with-paketo-builders |
on the other note, do you know how to achieve the same without probably the |
I don't sorry, I'm not that familiar with using creator directly. You could try asking on the CNB Github or Slack. |
Just a question on builder images - why does the builder image so large and have these many # of layers? I am not an expert on the buildpacks, but my understanding is that the builder contains the buildpacks definitions(textual metadata only), which if detected to be used, the buildpack would download the required binaries/packages to contribute the layer needed by that particular buildpack. for example, if my application is a springboot app, by using the |
The builder image is larger because of a couple of reasons:
The buildpack tooling can certainly do better about this, but at the moment it basically just pushes all of the buildpacks into the image each on its own layer. |
For what it's worth, this is now a problem with v13.0.0 and later when using New Relic. Until this is addressed, does it make sense to remove another buildpack(s) (e.g. datadog, node, yarn) and let users add those that they might need? I realize this is a breaking change, but New Relic customers cannot upgrade otherwise from what I can tell. |
We can't easily remove buildpacks because folks now expect them to be there and it's part of the contract with what we ship. You can work around this by using the buildpack-less builder though.
or
However, we've seen this to be more of an issue with Spring Boot Build Tools, and not pack. See #1392 (comment) |
Thanks @dmikusa, that worked and wasn't aware of the buildpackless builders. |
Describe the Enhancement
Can the newrelic buildpack be included in this java builder.
Motivation
This java builder seems to be including other application monitoring platforms (datadog, google stakedriver, azure application-insights), Including newrelic buildpack would make it useful for those who use the platform.
The text was updated successfully, but these errors were encountered: