From dbd0f413b1f18c550b2ab5da0764c135f6508605 Mon Sep 17 00:00:00 2001
From: Brendan Thomas <brthomas@covermymeds.com>
Date: Mon, 23 May 2016 15:40:38 -0400
Subject: [PATCH] Rubocop solution

---
 GemCity.rb       | 56 ------------------------------------------------
 gem_city.rb      | 55 +++++++++++++++++++++++++++++++++++++++++++++++
 gem_city_spec.rb |  6 +++---
 3 files changed, 58 insertions(+), 59 deletions(-)
 delete mode 100644 GemCity.rb
 create mode 100644 gem_city.rb

diff --git a/GemCity.rb b/GemCity.rb
deleted file mode 100644
index 690dc84..0000000
--- a/GemCity.rb
+++ /dev/null
@@ -1,56 +0,0 @@
-class GemCity
-
-=begin
-This class represents the town of GemCity
-This is a town riddled with crime but we can find out how happy the town is
-=end
-  def initialize
-    @people, @population = {
-     :thieves => 5, 
-       :Officers => 1},
-       50
-    end
-
-  def thieves thieves_number=@people[:thieves]
-     return @people[:thieves] = thieves_number
-  end
-
-  def officers
-    return @people[:Officers] 
-  end
-
-  def population; return @population; end
-
-  def setOfficers officers
-    @people[:Officers] = officers
-  end
-
-  def happiness_of_town
-    #happiness is random... people don't know what they want!
-    happinessVals = Array.new
-     happiness = 0
-    for index in (1..@population)
-      happinessVals.push(rand((100 - successful_crime_rate) .. 100))
-      index += 1
-    end
-    happinessVals.each do |value|
-      happiness += value
-    end
-    return happiness / 100
-  end
-
-  def successful_crime_rate
-    thieves = @people[:thieves]
-    officers = @people[:Officers]
-    if thieves <= 0
-      odds_percent = 0
-    elsif officers > thieves
-      odds_percent = 0
-    else
-      odds = 1 \
-       - officers.to_f / thieves.to_f
-      odds_percent = odds * 100
-    end
-    return odds_percent
-  end
-end
\ No newline at end of file
diff --git a/gem_city.rb b/gem_city.rb
new file mode 100644
index 0000000..6645bee
--- /dev/null
+++ b/gem_city.rb
@@ -0,0 +1,55 @@
+# This class represents the town of GemCity
+# This is a town riddled with crime but we can find out how happy the town is
+class GemCity
+  attr_reader :population
+
+  def initialize
+    @people = {
+      thieves: 5,
+      officers: 1
+    }
+    @population = 50
+  end
+
+  def thieves(thieves_number = @people[:thieves])
+    @people[:thieves] = thieves_number
+  end
+
+  def officers
+    @people[:officers]
+  end
+
+  def num_officers(officers)
+    @people[:officers] = officers
+  end
+
+  def happiness_of_town
+    # happiness is random... people don't know what they want!
+    happiness_vals = []
+    happiness = 0
+    index = 0
+
+    until index >= @population
+      happiness_vals.push(rand((100 - successful_crime_rate)..100))
+      index += 1
+    end
+
+    happiness_vals.each { |value| happiness += value }
+
+    happiness / 100
+  end
+
+  def successful_crime_rate
+    thieves = @people[:thieves]
+    officers = @people[:officers]
+
+    if thieves <= 0 || officers > thieves
+      odds_percent = 0
+    else
+      odds = 1 - officers.to_f / thieves.to_f
+      odds_percent = odds * 100
+    end
+
+    odds_percent
+  end
+end
diff --git a/gem_city_spec.rb b/gem_city_spec.rb
index 884b3cb..7f86ee2 100644
--- a/gem_city_spec.rb
+++ b/gem_city_spec.rb
@@ -1,5 +1,5 @@
 require 'rspec'
-require_relative 'GemCity' # This line may need to be changed
+require_relative 'gem_city' # This line may need to be changed
 
 describe 'Gem City' do
   let(:city) { GemCity.new }
@@ -16,7 +16,7 @@
 
     it 'officers = thieves' do
       city.thieves 1
-      city.setOfficers 1 # This line may need to be changed
+      city.num_officers 1 # This line may need to be changed
       expect(city.successful_crime_rate).to eq(0)
     end
 
@@ -27,7 +27,7 @@
 
     it 'officers > thieves' do
       city.thieves 1
-      city.setOfficers 2 # This line may need to be changed
+      city.num_officers 2 # This line may need to be changed
       expect(city.successful_crime_rate).to eq(0)
     end
   end