PDT24-45 | Fix Docker Hot-Reloading #11
Conversation
noxiousghost
requested review from
Nijarshrestha,
arjandhakal,
rrojan and
pratham-outside
* feat: add logging service with winston * chore(logging): use and fix logging information * PDT24-34 | Configure nodemailer service (#12) * feat: configure nodemailer servie for sending email * feat: create a basic email template for sending signup otp code * chore: rename param names and add function documentation * fix: use secure mailing port * refactor: remove sendEmail call from main and improve sendEmail method * refactor: remove ternary operator
|
| new transports.File({ filename: 'logs/errors.log', level: 'error' }), | ||
| new transports.File({ filename: 'logs/all.log' }), |
There was a problem hiding this comment.
Use { flags: 'a' } to append to log file instead of overwriting it on each rebuild.
There was a problem hiding this comment.
It turns out that the existing code (without flags: 'a') works just fine. It doesn't overwrite the log files on each rebuild. so I am leaving as it is
| ), | ||
| transports: isProduction | ||
| ? [ | ||
| new transports.File({ filename: 'logs/errors.log', level: 'error' }), |
There was a problem hiding this comment.
If possible, store logs for different dates in different log files.
E.g. errors_2024-12-32.log
To stay clear of potential timezone issues, use server time or UTC.
There was a problem hiding this comment.
For this we'd have to install an additional package called winston-daily-rotate-file. Do you recommend to do so?
| from: sender ?? { | ||
| name: process.env.EMAIL_SENDER_NAME as string, | ||
| address: process.env.EMAIL_USER as string, |
There was a problem hiding this comment.
You can define this as a constant somewhere with Address type so it can be reused across your MailerModule
There was a problem hiding this comment.
instead, i removed sender as it will be constant across the application.
Tasks
Changes