Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Discord OAuth2 #25

Merged
merged 8 commits into from
Jul 27, 2024
Merged

Added support for Discord OAuth2 #25

merged 8 commits into from
Jul 27, 2024

Conversation

f-fsantos
Copy link
Contributor

No description provided.

@f-fsantos f-fsantos marked this pull request as ready for review June 6, 2024 22:21
CodeTappert
CodeTappert reviewed Jun 7, 2024
View reviewed changes
api/account/discord.go Outdated Show resolved Hide resolved
CodeTappert
CodeTappert reviewed Jun 7, 2024
View reviewed changes
api/account/google.go Outdated Show resolved Hide resolved
CodeTappert
CodeTappert reviewed Jun 7, 2024
View reviewed changes
api/account/google.go Outdated Show resolved Hide resolved
CodeTappert
CodeTappert reviewed Jun 7, 2024
View reviewed changes
api/account/info.go Outdated Show resolved Hide resolved
CodeTappert
CodeTappert reviewed Jun 7, 2024
View reviewed changes
api/endpoints.go Outdated Show resolved Hide resolved
CodeTappert
CodeTappert reviewed Jun 7, 2024
View reviewed changes
api/endpoints.go Outdated Show resolved Hide resolved
CodeTappert
CodeTappert reviewed Jun 7, 2024
View reviewed changes
api/endpoints.go Outdated Show resolved Hide resolved
CodeTappert
CodeTappert reviewed Jun 7, 2024
View reviewed changes
api/endpoints.go Outdated Show resolved Hide resolved
CodeTappert
CodeTappert reviewed Jun 7, 2024
View reviewed changes
api/endpoints.go Outdated Show resolved Hide resolved
CodeTappert
CodeTappert reviewed Jun 7, 2024
View reviewed changes
api/endpoints.go Outdated Show resolved Hide resolved
CodeTappert
CodeTappert reviewed Jun 7, 2024
View reviewed changes
api/endpoints.go Outdated Show resolved Hide resolved
CodeTappert
CodeTappert approved these changes Jun 7, 2024
View reviewed changes
Copy link

@CodeTappert CodeTappert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes made are good. All other things were talked about with the dev. They are not supposed to be changed (in this PR).

So approved

brain-frog and others added 2 commits July 10, 2024 20:03
@brain-frog @f-fsantos
Need a login check
cb68bd1
@f-fsantos
chore: Add Discord OAuth2 authentication endpoint
262a048 
chore: Update dependencies and clean up code

chore: Update dependencies, add Discord OAuth2 authentication endpoint, and clean up code

chore: Update dependencies, add Google OAuth2 authentication endpoint, and clean up code

Code clean up

uniqueness on external account id

chore: Add Discord and Google OAuth2 authentication endpoints, and update dependencies

code review fixes
@patapancakes patapancakes merged commit fa57f59 into pagefaultgames:master Jul 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeTappert CodeTappert CodeTappert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@f-fsantos @CodeTappert @patapancakes @brain-frog