[Refactor] Improve imports #4703
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should hopefully prevent most merge conflicts with imports
- Replace `* as Utils` with `{ ... }`
- Replace instances of `IntegerHolder` with `NumberHolder`
- Add `#phases`, `#mystery-encounters`, `#balance` import mappings
- Replace many instances of relative with absolute imports
DayKev
added
Miscellaneous
|
434 files changed :darumastare: |
|
I don't expect this to go in to the current beta, so there will be plenty of time next cycle to review the non-functional changes. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
N/A
Why am I making these changes?
I got tired of fixing annoying merge conflicts from imports that were hundred of characters long. It would be even better if it were possible to apply "Organize Imports" globally but that causes issues :pikastare:. Maybe in the future...
Hopefully this can turn a recurring issue into a one-time changeover.
What are the changes from a developer perspective?
* as Utilsreplaced with{ ... }IntegerHolderreplaced withNumberHolder#phases(#app/phases),#mystery-encounters(#app/data/mystery-encounters) and#balance(#app/data/balance) import mappingsHow to test the changes?
npm run testChecklist
betaas my base branch[ ] Have I considered writing automated tests for the issue?[ ] If I have text, did I make it translatable and add a key in the English locale file(s)?npm run test)[ ] Are the changes visual?[ ] Have I provided screenshots/videos of the changes?