Are maintainability refactors welcome? #4967
Unanswered
AQuackenbos
asked this question in
Q&A
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hello!
I'm a Typescript developer, and I've been working on a small item from the issues list recently and preparing to open the PR. However, as a more general question, I was wondering if refactors/restructures aimed at maintainability are welcome in this project?
Some files, such as
src/data/move.ts
, could be broken up into more manageable pieces that feed back into the same exports; in other classes, such as the primary entry insrc/ui/battle-info.ts
, manually define several entries that could be encapsulated into discrete entries that would make it easier to perform updates with less fear of regression bugs. I'm just wondering if structural refactors like that are welcome in the PR list, or if the monolithic class structure is preferred by the primary maintainers.Thank you!
Beta Was this translation helpful? Give feedback.
All reactions