Fix targets override identifier in check rerun and failed builds related test retriggering #2665
+388
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed. ✔️ pre-commit SUCCESS in 2m 09s |
majamassarini
force-pushed
the
fix-targets-override-identifier-in-check-rerun
branch
from
e785121
to
cf31081
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 09s |
lbarcziova
approved these changes
Nov 29, 2024
In the code we are already using both without casting. So I stay consistent. I hope this will not a problem with serialization/deserialization.
Otherwise there is no override and everything is retriggered.
for more information, see https://pre-commit.ci
majamassarini
force-pushed
the
fix-targets-override-identifier-in-check-rerun
branch
from
7e955d0
to
8118907
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 03s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 03s |
softwarefactory-project-zuul
bot
merged commit bc265c4
into
packit:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1519 #1886
RELEASE NOTES BEGIN
We have fixed
/packit retest-failedwhich was retriggering also non failed tests.RELEASE NOTES END