Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Euphonic Calculations: Implement analytic powder-averaged incoherent spectra in Euphonic #67

Open
ajjackson opened this issue Feb 5, 2020 · 6 comments

Comments

@ajjackson
Copy link
Collaborator

ajjackson commented Feb 5, 2020

Blocking #24

This is essentially a port of the method implemented in Abins to the framework of Euphonic.

It is likely to be held back by the complicated design of Abins, which includes caching and achieves some processes via side-effects. It may be necessary to escalate the priority of an existing goal, refactoring this to a more explicit "functional" design.

Abins refactoring work has been progressing to unblock this. The first two stages of major Abins refactoring

  • renaming/reorganising
  • overhauling data classes
    have been completed.

The remaining stage is to overhaul the caching system and related data flow. (#165 )

@ajjackson ajjackson self-assigned this Feb 5, 2020
@stfc-lam stfc-lam changed the title Implement analytic powder-averaged incoherent spectra in Euphonic Euphonic Calculations: Implement analytic powder-averaged incoherent spectra in Euphonic Feb 21, 2020
@stfc-lam stfc-lam removed this from the Sprint 19/02/2020 to 04/03/2020 milestone Mar 4, 2020
@cmarooney-stfc
Copy link
Collaborator

@ajjackson Hi Adam, I'm looking through the project board, and this one has been blocking for a long time. Could you say what the plans are for this? It would be good to reference the work noted in the description through its tickets. thanks Chris - I've not commented on #68 separately but it would be useful to do the same for that ticket.

@ajjackson
Copy link
Collaborator Author

ajjackson commented Feb 17, 2021

This is the proposal to move some existing Abins functionality into the Euphonic package. (Specifically, the computation of incoherent spectra with analytic powder-averaging equations.) It is blocked by other work on Abins:

@cmarooney-stfc
Copy link
Collaborator

@ajjackson Thanks Adam. Do you have ticket numbers for the two bullet-pointed tasks you mention? That will help us keep track of the process

@ajjackson
Copy link
Collaborator Author

I've been treating these as part of Abins project management rather than PACE project management, but I can create PACE tickets if that helps.

@cmarooney-stfc
Copy link
Collaborator

cmarooney-stfc commented Feb 22, 2021

@ajjackson As we're tracking this in the pace board and it is a euphonic implementation, I think some of this would be useful. While the Abins refactor is strictly not part of that, it is impacting Euphonic so it would be useful to track it. Thanks for creating the pace tickets. If you think it's helpful, you could cross-reference to abins

@ajjackson
Copy link
Collaborator Author

Issues have now been created and links added to earlier posts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants